Skip to content

RC: Redis hashing policy #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 1, 2025
Merged

RC: Redis hashing policy #1139

merged 17 commits into from
Apr 1, 2025

Conversation

@cmilesb
Copy link
Contributor

@cmilesb cmilesb commented Feb 6, 2025 •
edited
Loading

Releasing 3/30.

Need to retake flexible-add-database-basic.png

@cmilesb cmilesb added the rc Redis Cloud docs label Feb 6, 2025
@cmilesb cmilesb requested a review from yoavredis February 6, 2025 21:36
@cmilesb cmilesb self-assigned this Feb 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited
Loading

Staging links:
https://redis.io/docs/staging/DOC-4745/operate/rc/changelog/february-2025
https://redis.io/docs/staging/DOC-4745/operate/rc/changelog/march-2025
https://redis.io/docs/staging/DOC-4745/operate/rc/databases/configuration/clustering
https://redis.io/docs/staging/DOC-4745/operate/rc/databases/create-database/create-pro-database-new
https://redis.io/docs/staging/DOC-4745/operate/rc/databases/view-edit-database
https://redis.io/docs/staging/DOC-4745/operate/rc/databases/create-database/create-pro-database-existing
https://redis.io/docs/staging/DOC-4745/operate/rc/databases/create-database/create-pro-database-new

@yoavredis yoavredis requested a review from joniredis February 10, 2025 11:42
cmilesb
cmilesb commented Feb 11, 2025
View reviewed changes
yoavredis
yoavredis reviewed Feb 18, 2025
View reviewed changes
yoavredis
yoavredis reviewed Feb 18, 2025
View reviewed changes
yoavredis
yoavredis requested changes Feb 18, 2025
View reviewed changes
Copy link

@yoavredis yoavredis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmilesb I've added inline comments.
LMK if you have any Qs.
10x

cmilesb
cmilesb commented Feb 18, 2025
View reviewed changes
cmilesb
cmilesb commented Feb 18, 2025
View reviewed changes
@cmilesb cmilesb requested a review from yoavredis February 19, 2025 14:55
yoavredis
yoavredis approved these changes Feb 20, 2025
View reviewed changes
Copy link

@yoavredis yoavredis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmilesb LGTM, 10x.
@joniredis please review and approve, especially the "For accounts created after MONTH DAY, 2025," statements.

@cmilesb cmilesb requested a review from a team February 20, 2025 17:58
@cmilesb cmilesb marked this pull request as ready for review February 20, 2025 17:58
andy-stark-redis
andy-stark-redis approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions but basically LGTM.

@cmilesb @andy-stark-redis
Apply suggestions from code review
bc3e000 
Co-authored-by: andy-stark-redis <[email protected]>
@cmilesb cmilesb requested review from a team, andy-stark-redis and yoavredis March 13, 2025 15:06
andy-stark-redis
andy-stark-redis approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically minor suggestions (the comment about referrring to search and query implicitly as a data type is probably the most important one), but I'll approve anyway.

@cmilesb @andy-stark-redis
Apply suggestions from code review
7677d97 
Co-authored-by: andy-stark-redis <[email protected]>
@cmilesb cmilesb mentioned this pull request Mar 17, 2025
Merged
@cmilesb cmilesb requested a review from a team March 27, 2025 19:39
andy-stark-redis
andy-stark-redis approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one very minor suggestion that you're free to ignore :-) Otherwise, LGTM.

yoavredis
yoavredis approved these changes Mar 30, 2025
View reviewed changes
Copy link

@yoavredis yoavredis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmilesb LGTM, 10x.
We go with "after March 30, 2025" if no last-minute surprises.
I will DM you with a final GO on March 31st, once we've released.

cmilesb
cmilesb commented Apr 1, 2025
View reviewed changes
@cmilesb cmilesb merged commit 8314d28 into main Apr 1, 2025
5 checks passed
@cmilesb cmilesb deleted the DOC-4745 branch April 1, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoavredis yoavredis yoavredis approved these changes

@andy-stark-redis andy-stark-redis andy-stark-redis approved these changes

@joniredis joniredis Awaiting requested review from joniredis

Assignees

@cmilesb cmilesb

Labels

do not merge yet rc Redis Cloud docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cmilesb @yoavredis @andy-stark-redis